crates.io: Enable `rustbot`

rust-lang / team

Rust teams structure

Apache License 2.0

312 stars 287 forks source link

crates.io: Enable `rustbot` #1568

Closed Turbo87 closed 1 month ago

Turbo87 commented 1 month ago

r? @rust-lang/infra

Turbo87 commented 1 month ago

If you think this PR should have been approved by the team-repo-admins team instead, please reach out and let's discuss this

I don't think that's necessary for this PR

MarcoIeni commented 1 month ago

I chatted with JD, the general rule is that infra only merge changes to .rs files, so I'll wait for the team-repo-admins to merge this 👍

Turbo87 commented 1 month ago

r? @rust-lang/team-repo-admins 🙏

Turbo87 commented 1 month ago

side note: this is a change related to the crates.io repository, which is managed by the crates.io team. why does it need approval from @rust-lang/team-repo-admins? if anything it feels like it would need approval from the @rust-lang/crates-io team instead?

the amount of work, bureaucracy and approvals necessary to get an issue moved is quite staggering...

Kobzol commented 1 month ago

This specific change is very unlikely to really need approval from team-repo-admins, but in general it's quite hard to design a heuristic for this. Therefore, so far the consensus is that (at least TOML) changes need approval from team-repo-admins. I think that it would be great if we could grow that team though..

MarcoIeni commented 1 month ago

I think it's worth discussing this in zulip or in a separate GitHub issue 👍

Turbo87 commented 1 month ago

@rust-lang/team-repo-admins is anything blocking this from your side? do you need more information? what can I do to speed up this process?

ChrisDenton commented 1 month ago

I think most/all of the admins are away atm. Nothing has been merged in a week.