rerunning on fixpoint change on overflow with non-trivial constraints - Githubissues

rust-lang / trait-system-refactor-initiative

The Rustc Trait System Refactor Initiative

22 stars 0 forks source link

rerunning on fixpoint change on overflow with non-trivial constraints #128

Open lcnr opened 2 months ago

lcnr commented 2 months ago

we do this

it's pointless as we do not apply any constraints if a goal encountered overflow.

https://github.com/rust-lang/rust/blob/1f44f0a66fa0892ca680a26e271d22993d53de5c/compiler/rustc_next_trait_solver/src/solve/eval_ctxt/mod.rs#L401-L417

given that we now always discard overflow, we should probably just clear the query result inside of the query instead of in the caller :sweat_smile: