search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
177 stars 75 forks source link

Rename the entire zulip topic when an MCP issue is renamed. Fixes #1228. #1588

Closed ghost closed 2 years ago

ghost commented 2 years ago

See comment here. Note that I don't have a local dev instance and haven't been able to verify this change myself.

Mark-Simulacrum commented 2 years ago

Thanks! My guess is this is an API change upstream -- I don't recall seeing https://zulip.com/api/update-message#parameter-propagate_mode before. But this seems like the right setting.

ghost commented 2 years ago

I think I may have misunderstood this bug possibly, I added an additional comment on #1228. I think the actual issue is that renaming the topic works but would end up breaking the link left on the MCP?

ghost commented 2 years ago

@Mark-Simulacrum I'm not 100% sure this should be merged based on my last comment, I think my fix may have been premature. (sorry 😿)

Mark-Simulacrum commented 2 years ago

I think this is the right fix, it may just be incomplete -- we definitely want to update the full thread on Zulip, but it may also be the case that the GitHub link to the Zulip topic is not currently updated. I suspect that should just require clicking through the 'stub' thread left by the renaming though; not really different to today.

ghost commented 2 years ago

Ok, cool. I'm also reading through Resolving topics breaks links by changing the topic name! and Provide permalinks to reference streams, topics and messages. right now.

I wonder if just having an additional comment posted by rustbot on the github issue would be sufficient? Editing the original comment with an updated link would be nice, but would also be trickier.

Mark-Simulacrum commented 2 years ago

An additional comment seems OK to me.