search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
172 stars 73 forks source link

After renaming zulip topic, post a comment under the old topic pointing to the new topic #1590

Closed ghost closed 2 years ago

ghost commented 2 years ago

After renaming zulip topic (#1588), post an additional comment under the old (now empty) topic pointing to the newly renamed topic. Fixes #1228.

Alternative to #1589. Although #1589 could potentially still be applied. it would just be somewhat redundant.

cc @Mark-Simulacrum @apiraino

apiraino commented 2 years ago

that's really cool @skippy10110 , thanks!

ghost commented 2 years ago

Thanks for the great suggestion!

ghost commented 2 years ago

This might become fixed natively by zulip in zulip/zulip#15290, https://github.com/zulip/zulip/commit/f0c680e9c0d1a62fd414bccc82e4ac255173aaa9 !

I just tried it quickly, but I suppose I need to wait for that commit to actually makes its way through to our zulip instance :)

Edit: nevermind :) the topic link portion wasn't fixed and a new issue is up now for that: zulip/zulip#21505

Mark-Simulacrum commented 2 years ago

Hi! @skippy10110 I'm happy to merge or not merge -- not very clear on the status here. Could you provide an update?

ghost commented 2 years ago

this is all ready to go on my end if you're fine with the change (with the caveat that i have no way to test the change until it's live)

ghost commented 2 years ago

i'm not sure if it's actually been reviewed by anyone, if you want to take a look also

ghost commented 2 years ago

@Mark-Simulacrum, do you know if this should be live yet? I just tried it out and didn't see the new comment post.

Mark-Simulacrum commented 2 years ago

It should have deployed automatically, but I won't get a chance to check that today most likely.

Mark-Simulacrum commented 2 years ago

It looks like we weren't successfully deploying (unfortunately, we don't really have alarms for this currently), due to an outdated glibc version. The good news is that for once health checks worked so the previous deployment remained live; the bad news is that this patch didn't actually go out.

With https://github.com/rust-lang/triagebot/pull/1612 merged and now deployed this should also be in production now.

ghost commented 2 years ago

phew 😊 thanks for letting me know, i just tested it out and it's working great!

https://rust-lang.zulipchat.com/#narrow/stream/243200-xxx/topic/TRIAGEBOT.20TESTING.3A.20Please.20ignore.20lang-team.23148