search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
177 stars 75 forks source link

Relax parsing of labels #1591

Closed mbartlett21 closed 2 years ago

mbartlett21 commented 2 years ago

Let it accept more commands

Mark-Simulacrum commented 2 years ago

Sorry this slipped by my radar for so long -- I think it looks good overall, just one small comment.

mbartlett21 commented 2 years ago

@Mark-Simulacrum I've simplified the parsing (and allowed using @rustbot labels to: +this -that), and updated the tests to test various inputs.

@rustbot ready

rustbot commented 2 years ago

Error: The feature shortcut is not enabled in this repository. To enable it add its section in the triagebot.toml in the root of the repository.

Please let @rust-lang/release know if you're having trouble with this bot.

mbartlett21 commented 2 years ago

@Mark-Simulacrum

These are the tests that are failing now, since I allowed @bot labels to: +this. Should these still provide a MisleadingTo error?

https://github.com/rust-lang/triagebot/blob/83f7a8df8483954e8e6e59feb1a80b1f111c228c/parser/src/command/relabel.rs#L270-L292

Mark-Simulacrum commented 2 years ago

Probably that shouldn't be an error anymore.

mbartlett21 commented 2 years ago

@Mark-Simulacrum Ok. This is ok to merge now.