search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
172 stars 73 forks source link

The "Ready" shortcut should work on pull request review comments #1614

Closed jyn514 closed 2 years ago

jyn514 commented 2 years ago

Right now it only works on top-level comments, not review comments.

Originally posted by @rustbot in https://github.com/rust-lang/rust/issues/96584#issuecomment-1115720413

apiraino commented 2 years ago

I'm trying to reproduce this on a local triagebot installation but so far no success.

@ehuss any suggestion? I see many occurrences of this in the rust-lang/rust pull requests but I'm blind since I don't have access to the logs (and we don't have a test repository, do we?)

Mark-Simulacrum commented 2 years ago

I believe this is fixed -- I added logic but failed to close this issue (probably due to not knowing about it) to resolve this in https://github.com/rust-lang/triagebot/pull/1619.

apiraino commented 2 years ago

oh. Now I see :)