search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
172 stars 73 forks source link

Remove redundant queries to rfcbot.rs #1624

Closed apiraino closed 2 years ago

apiraino commented 2 years ago

Queries to rfcbot.rs are enabled by a boolean flag include_fcp_details, so when this flag is false it's not necessary to run those queries.

r? @spastorino

thanks for the review!

Mark-Simulacrum commented 2 years ago

Is there some problem with these queries (other than wasted bandwidth)? I would expect rfcbot.rs to be pretty fast, but I could be wrong.

apiraino commented 2 years ago

No other problem to my knowledge, just redundant queries.

(encountered this while inspecting the traffic when building the T-compiler agenda)

EDIT: for context, when generating the T-compiler agenda, I see ~25Kb (compressed) * 39 queries to https://rfcbot.rs/api/all which this patch removes.