search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
170 stars 74 forks source link

Don't post mentions on rollups. #1631

Closed ehuss closed 2 years ago

ehuss commented 2 years ago

People don't need to be pinged on a rollup PR, so this tries to skip them.

An alternate approach would be to scan the issue body for something like @rustbot modify labels: rollup, but I think looking at the title should work well enough.

This won't handle beta backports, though. I'm wondering if maybe it should ignore the beta branch? I don't know if those pings will happen often enough to be annoying.

jyn514 commented 2 years ago

Can we look for the rollup label instead? I think that should be more reliable.

I guess it's not added until after the PR is created though ... would be nice if we could change bors to have it in the initial PR so we can depend on it.

Mark-Simulacrum commented 2 years ago

I'm going to merge this for now to avoid noise for contributors; we can improve it to handle the edge cases (e.g., beta, etc) later.