search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
170 stars 74 forks source link

Revert pull_request field change. #1653

Closed ehuss closed 1 year ago

ehuss commented 1 year ago

The change to the pull_request field in #1646 is causing way more trouble than it is worth. If GitHub sometimes populates this field, then it is useful to know if it is a pull request or not.

Fixes #1651.

apiraino commented 1 year ago

For future notice, should this codepath will be changed: #1646 also was breaking the T-compiler agenda generation (specifically commit 3cde23dfb9a6b2e724d0c5e4257aae6cf6276eee) when running the triagebot command cargo run --bin prioritization-agenda.

Just mentioning this because some dependencies are not always apparent with this codebase. A good strategy could be to run all three CLI binaries of the triagebot (compiler,lang,prioritization-agenda) for a quick sanity check.

Anyway, no problem, this patch reverts the breaking change :)