search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
170 stars 74 forks source link

Update to cynic 2.0 #1671

Closed obmarg closed 1 year ago

obmarg commented 1 year ago

I'm the author of cynic, the graphql client library this project is using. I just released v2 of cynic, so thought I'd raise a PR that updates triagebot to use it.

I've put some effort into improving compile times for large schemas in this release. In my (not very scientific) tests the github-graphql crate in this repo compiles in about half the time after these changes. Frankly it's still not as fast as I'd like but the github schema is a real challenge.

I also simplified a few of your queries & the associated handling code, hope that's ok. Happy to revert that stuff if not though.

apiraino commented 1 year ago

hey @obmarg great to see you around :) I love cynic, thanks for this patch!

At a cursory look it looks great. I'd leave it sink for a a bit so I can try it this week for the T-compiler meeting.

(but tbh I'm also fine to straight merge this if the triagebot maintainers say so)

Mark-Simulacrum commented 1 year ago

@obmarg Hi! Thanks for this patch, this is great. It looks like we've edited the graphql we use a little since you made it (sorry!), but I'd be happy to merge a rebased version of it.

obmarg commented 1 year ago

No worries @Mark-Simulacrum - have rebased & updated the new query