search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
170 stars 75 forks source link

Strip words after `@rustbot claim` #1685

Closed KittyBorgX closed 1 year ago

KittyBorgX commented 1 year ago

Usually running something like: @rustbot claim :) raises an error: 

Error: Parsing assign command in https://github.com/rust-lang/rust/issues/108621#issuecomment-1451148647 failed: ...' claim' | error: expected end of command at >| ' :)'...

Please file an issue on GitHub at [triagebot](https://github.com/rust-lang/triagebot) if there's a problem with this bot, or reach out on [#t-infra](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra) on Zulip.

Idea : Strip all the text after the claim, only for the claim command to be able to do something like what I had mentioned earlier.

Mark-Simulacrum commented 1 year ago

We have some symbols we accept as stop for commands (e.g., IIRC .), maybe : makes sense there too.

Part of the reason for restricted parsing is that if that command changes to accept something after it, we don't want to re-parse the command differently in e.g. a comment edit or similar.

KittyBorgX commented 1 year ago

Got it! Thanks!