search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
172 stars 74 forks source link

Rustfmt #1715

Closed ehuss closed 1 year ago

ehuss commented 1 year ago

Rustfmt now formats let-else, which is causing CI to fail.

apiraino commented 1 year ago

I'm all for using linters with their defaults, but in this case would it be worth trying to silent that lint? How many other areas of the triagebot code would that lint change is we go and open a file?

I'm not greatly familiar with the rustfmt rules, maybe this one? single_line_let_else_max_width set to something high.

ehuss commented 1 year ago

Since let-else is relatively new, I don't think there has been a lot of opportunities for people to use it, so I suspect that's why there aren't a lot of changes.

I think it would be good to merge this in order to fix CI.

As for the question about changing the rustfmt settings, I don't have an opinion. I'm happy either way, but I think it would be good to follow up on that separately so that it doesn't block other PRs.