rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
170 stars 75 forks source link

New pull request assignment proposal #1719

Closed apiraino closed 7 months ago

apiraino commented 10 months ago

This patchset is the implementation of a new workflow for assigning pull requests to the Rust project contributors.

2023-11-08 UPDATE: After a meeting with T-infra, it was remarked that this block of changes are hard to review, so we agreed a plan to split into smaller bites. This PR will stay as tracking issues for the work being split into smaller pull requests:


A slightly old design document is at this HackMD link.

This proposal was discussed separately in a number of meetings with the compiler team (also mentioned to @Mark-Simulacrum).

Summary

The current pull request assignment is basically randomly assigned among team members. The new proposed workflow has the following features:

Permissions and Authorization

This backoffice is a simple form listing all team members. It is served by the triagebot (from triagebot.infra.rust-lang.org/). Access to this backoffice is gated by a GitHub App. Users allowed to this backoffice: 1) must be logged into GitHub 2) must agree to the share some details with a GitHub App (only to read their profile) 3) must be a Rust project team member 4) the team they belong must be whitelisted in the env var NEW_PR_ASSIGNMENT_TEAMS (see documentation)

Team leaders are considered administrators and can see the preferences of every team member. Normal team members can only see their own preferences and those of team members that agree to share theirs within the team.

DEPLOYMENT

There are a few env vars to enable the new PR assignment and retrict access to this backoffice (see: .env.sample).

My idea would be to iterate on this pull request and iron out all the wrinkles visible without deployment:

Of course, happy to receive inputs!

TODO

I also left a few notes about a few items to be implemented, in my opinion also in a second interation; see the documentation.


(I will iterate on the pull request description to add context)

apiraino commented 7 months ago

Closing and restarting from scratch in #1753