Closed apiraino closed 9 months ago
Just being nit-picky, but it seems like this will fail if there is a legitimate user with a t-
prefix like t-eric
? It can be fixed if there is ever a user like that, just wanted to point it out.
Just being nit-picky, but it seems like this will fail if there is a legitimate user with a
t-
prefix liket-eric
?
Or ever a user with github handle t-
(which exists :slightly_smiling_face:). Anyway, totally fair point and in that case the team name check must be shortcircuited before by another check if the provided full string being examined is actually a team member
Improve a little bit the team label parser. Accept and fix wrong labels like
t-*
orT-*
(sometimes we mix up Zulip stream names and actual team names).I'd not document this in the triagebot wiki because I'd prefer not to encourage using
t-*
labels. This patch will be our little secret 😇Mentioned on Zulip.
r? @ehuss
thanks!