search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
169 stars 75 forks source link

Use rfcbot style for FCPs in the prioritization agenda #1784

Closed Urgau closed 2 months ago

Urgau commented 3 months ago

This PR add the necessary information to replicate the rfcbot style when showing FCPs and uses it in the prioritization agenda.

One thing at isn't perfect is that we are using the Github login and not the Zulip login, using the Zulip username would require accessing the team database which I didn't wanted to do yet but could be done as a follow up PR. (fixed, https://github.com/rust-lang/triagebot/pull/1784#issuecomment-2016833448)

r? @apiraino

They would now look like this (modulo the mentions). Full example here.

Urgau commented 3 months ago

I've found a pretty neat trick. Zulip as a de-ambiguator syntax when pinging users with the same name, it works by specifying the Zulip ID after the name, like so @**Urgau|123456**; but if we omit the name and just provide the ID, like so @**|123456**, it will also ping the right person.

This greatly simplifies the process for us, as we don't have to query the name associated with the Zulip id. I've added this trick in the last commit.

apiraino commented 3 months ago

Enabling mentions to remind team members checking their boxes in FCPs could have been a follow-up PR because it is unclear how it should work. However, for the sake of merging this change, I will approve this PR. For now it is disabled and will be discussed with T-compiler if and how that could work.

Thanks @Urgau for suggesting this formatting for the FCPs.

r=me

apiraino commented 3 months ago

r? @jackh726 for the final word on this (I dont have permissions to approve)

Reverting my approval. I think this PR needs some more debugging

apiraino commented 2 months ago

@jackh726 we're done here, I think. When you have a sec feel free to have a look (and ofc leave a comment). thanks!