search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
169 stars 75 forks source link

"r?" silently does nothing when the user is not a reviewer #1805

Open RalfJung opened 2 months ago

RalfJung commented 2 months ago

In Miri, this is our configuration. If we now do r? @user, then nothing happens -- nobody gets assigned, but also no error is shown.

apiraino commented 2 months ago

Tried to look at the triagebot logs but don't have enough visibility. I suspect something fails when the triagebot tries to pick someone from this this file but I don't see errors, this could be why the silent failure.

ehuss commented 2 months ago

r? requires an assign.owners table to work. This was required to support the transition from highfive (so two bots didn't respond to every PR). Otherwise it is ignored.

It may be possible to do something like have an empty owners table to enable it and support something like #1806, but currently that is not supported. In the meantime, you can do the more explicit syntax of @rustbot assign @user