search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
169 stars 75 forks source link

Fix cargo milestoning timeout. #1819

Closed ehuss closed 2 weeks ago

ehuss commented 1 month ago

This fixes an issue where not all cargo PRs were getting milestoned.

The process of milestoning all the cargo PRs can take more than 10 seconds. This was causing the thread to get cancelled due to the webhook timeout.

This fixes the problem by spawning a background task to handle the milestoning process.

apiraino commented 3 weeks ago

just curious: do we know why adding a milestone takes long? By looking at #1751 I wonder if adding a milestone is more a "cronjob-like" task or it needs to be triggered manually on some other event.

ehuss commented 3 weeks ago

It needs to hit the set_milestone endpoint possibly a few dozen times. That endpoint seems fairly slow.