search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
169 stars 75 forks source link

Guard against overflowing GitHub ID comments #1821

Closed apiraino closed 2 days ago

apiraino commented 3 weeks ago

Recently we overflowed the ID counter for comments on GitHub.

This causes some comment IDs from this URL https://rfcbot.rs/api/all to be negative numbers.

This patch is a follow-up to this commit https://github.com/rust-lang/rfcbot-rs/commit/f9d84fa85b54296896bcbb2cf04049f783912ea6 to avoid some tooling (notably meetings agenda generators) crashing when retrieving comments with invalid IDs. It will not retrieve a comment that has an invalid ID (e.g. -2132153390)

More info about this incident at: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/rfcbot.20asleep/near/442898636

cc: @traviscross (we discussed this)

r? @jackh726 (thanks!)

apiraino commented 2 days ago

review plssss :bowing_man:

who can have a loook at this?