search

rust-lang / types-team

Home of the "types team", affiliated with the compiler and lang teams.
https://rust-lang.github.io/types-team/
Apache License 2.0
95 stars 19 forks source link

align rustc and chalk folder type #31

Open nikomatsakis opened 3 years ago

nikomatsakis commented 3 years ago
nikomatsakis commented 3 years ago

@rustbot assign @ LeSeulArtichaut

rustbot commented 3 years ago

Error: Parsing assign command in comment failed: ...'t assign @' | error: user should start with @ at >| ' LeSeulArt'...

Please let @rust-lang/release know if you're having trouble with this bot.

nikomatsakis commented 3 years ago

@rustbot assign @LeSeulArtichaut

LeSeulArtichaut commented 3 years ago

Let's try @rustbot claim

nikomatsakis commented 3 years ago

(cc @rust-lang/release -- any tips on how to make the triagebot work :)

Mark-Simulacrum commented 3 years ago

(Triagebot should work now, fixed the permissions).

eggyal commented 2 years ago

I understand from https://github.com/rust-lang/rust/pull/85485#issuecomment-908781112 that @LeSeulArtichaut isn't able to work on these at present. Would it be okay if I have a crack at moving them forward? I've already opened https://github.com/rust-lang/rust/pull/91230 to pick up where https://github.com/rust-lang/rust/pull/85469 left off.

@rustbot claim

eggyal commented 2 years ago

With rust-lang/rust#91230 merged, the first of these actions can be marked complete.

eggyal commented 1 year ago

The second action here had me confused for a while, until I spotted that TypeFamily was renamed Interner in rust-lang/chalk#329.

eggyal commented 1 year ago

With rust-lang/rust#107924 merged, rustc's folder is also now generic over the Interner (formerly Type Family).

And since chalk is no longer to be integrated with rustc, I guess further alignment of the folder types is not required?

jackh726 commented 1 year ago

Well, how are they still different? Might give some clues on if the rustc folder traits should be modified for some future solver state