search

rust-lang / types-team

Home of the "types team", affiliated with the compiler and lang teams.
https://rust-lang.github.io/types-team/
Apache License 2.0
95 stars 19 forks source link

Replace Travis CI with GHA #47

Closed JohnTitor closed 2 years ago

JohnTitor commented 2 years ago

On the rust-lang org, we've deprecated the use of Travis CI and migrated to GHA, this PR does it for this repo. Tested the gh-pages works fine on my fork: https://johntitor.github.io/types-team/ Note that I don't use the scripts on simpleinfra to deploy the gh-pages, as it's outdated and not recommended to use (I remember Pietro said it before, but cannot find the comment on GitHub...)

nikomatsakis commented 2 years ago

r? @rust-lang/infra

Mark-Simulacrum commented 2 years ago

Hm, did we repurpose a repo or something? Where did the Travis file come from - is there a template that needs adjusting?

jackh726 commented 2 years ago

@Mark-Simulacrum This repo got renamed wg-traits->types-team

JohnTitor commented 2 years ago

Hm, did we repurpose a repo or something? Where did the Travis file come from - is there a template that needs adjusting?

Looking at https://github.com/rust-lang/types-team/commit/2c992aecfed391e416e402e97bb6a4d04dbfee30, the reason would be "we weren't ready to use GHA (or GHA didn't exist) yet".

jyn514 commented 2 years ago

Note that I don't use the scripts on simpleinfra to deploy the gh-pages, as it's outdated and not recommended to use (I remember Pietro said it before, but cannot find the comment on GitHub...)

Can we update those scripts to use the code you have here so people can start using them again? That way we don't have to copy-paste these into each repo.

JohnTitor commented 2 years ago

Can we update those scripts to use the code you have here so people can start using them again? That way we don't have to copy-paste these into each repo.

IIRC the reason that it's not recommended is that action is based on Docker (@pietroalbini Am I correct?): https://github.com/rust-lang/simpleinfra/blob/master/github-actions/static-websites/Dockerfile It's generally slower than JavaScript's (or other forms of actions) so it isn't straightforward, I guess.

pietroalbini commented 2 years ago

Yeah, the existing Docker action is painfully slow. We should figure out a better solution, but in the meantime the code looks correct!

JohnTitor commented 2 years ago

Could anyone merge this?