rust-lang / vscode-rust

Rust extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=rust-lang.rust
Other
1.39k stars 167 forks source link

Scope of the project? #267

Open kdy1 opened 6 years ago

kdy1 commented 6 years ago

I want to merge some codes from https://github.com/swc-project/vscode-swc-devtools to this.

It contains a helper to start debugging with cargo, and I think it should live under rust-lang namespace.

nrc commented 6 years ago

Could you describe the features you'd like to merge in? I'd be happy to merge in useful and working functionality. Stuff that is work in progress might be a bit trickier, since we don't have a way to label features as unstable.

kdy1 commented 6 years ago

vscode has a debugging panel and vscode-cpptools supports gdb/lldb/msvc debugger but using it with cargo is bit tricky because binaries produced by cargo have name like cratename-XXXX which cannot be specified before cargo build is done.

That plugin invokes cargo test --no-run before launching debugger and then redirect it to vscode-cpptools.

nrc commented 6 years ago

OK, that seems reasonable. Could you make a PR so we can try out the functionality please? I assume users would need another extension installed to provide GDB or LLDB support? Is it possible to detect that and only offer the helper if it is present?

Xanewok commented 5 years ago

@kdy1 would you still be willing to submit a PR with proposed changes? I believe we'd like to include also debugging facilities as well.

kdy1 commented 5 years ago

@Xanewok Yes, I'll send a pr soon