Closed ehuss closed 4 years ago
Heh an excellent point! I think you're referring to this block, right? I think that this sort of logic (is_path()
) is taken into account in at least one other place (passing --cap-lints allow
vs not), but that may be the only other place that it's passed.
I wonder if the Package
could be updated here? Perhaps something like a "can this package be edited" property which enables/disables incremental/warnings and is default to true
for is_path
, but for libstd deps we can go through and rewrite these fields to "no, you can't edit this"
Sounds like a good idea to me.
Closed by https://github.com/rust-lang/cargo/pull/8177.
Incremental is not needed for std crates, so it should probably not be used.
I'm torn on exactly how to implement. Some options:
Profiles::get_profile
is_std
flag toUnit
, and check that when generating flags. This flag may be needed for other reasons, and would end up being the simplest change, but a bit of a hack.