rust-lang / wg-cargo-std-aware

Repo for working on "std aware cargo"
133 stars 8 forks source link

Disable incremental for std crates #44

Closed ehuss closed 4 years ago

ehuss commented 4 years ago

Incremental is not needed for std crates, so it should probably not be used.

I'm torn on exactly how to implement. Some options:

alexcrichton commented 4 years ago

Heh an excellent point! I think you're referring to this block, right? I think that this sort of logic (is_path()) is taken into account in at least one other place (passing --cap-lints allow vs not), but that may be the only other place that it's passed.

I wonder if the Package could be updated here? Perhaps something like a "can this package be edited" property which enables/disables incremental/warnings and is default to true for is_path, but for libstd deps we can go through and rewrite these fields to "no, you can't edit this"

ehuss commented 4 years ago

Sounds like a good idea to me.

ehuss commented 4 years ago

Closed by https://github.com/rust-lang/cargo/pull/8177.