search

rust-lang / www.rust-lang.org

The home of the Rust website
https://www.rust-lang.org
Apache License 2.0
362 stars 287 forks source link

Fix redirects #1924

Closed senekor closed 3 months ago

senekor commented 3 months ago

fix #1921

This regression was introduced in ca2a1621ece46315bdce0c1f76ed055f3d18a20a.

In the update from Rocket v0.5.0-rc.3 to v0.5.0, there was a breaking change missed in the changelog of v0.5.0-rc.4 that affected us. The relevant section in the changelog starts with the line: "The status codes used when built-in guards forward were changed."

We used the status code 404 to invoke our custom not_found catcher. This custom catcher is responsible for the redirects. When the status code changed to 422, this catcher was not invoked and the redirects were not triggered.

This fix simply invokes the catcher for both status codes 404 and 422.

Manishearth commented 3 months ago

we should check this works on staging (usually takes ~20min max to deploy) and then deploy

apiraino commented 3 months ago

thanks @senekor !