search

rust-leipzig / wiki

Markdown based wiki written in Rust
MIT License
17 stars 4 forks source link

How handle clippy results #61

Closed Drogglbecher closed 7 years ago

Drogglbecher commented 7 years ago

Since pull request #60 we integrated clippy checking to the nightly build to avoid such things like fixed in pull request #59. Unfortunately clippy currently only works for nightly build and since this is allowed to fail in our CI we won't get the infos. Nevertheless the warnings and errors are very meaningful. So we have the option to no longer allow nightly builds to fail or we have to extract the clippy results in another way, Any ideas or suggestions? ;)

saschagrunert commented 7 years ago

I would simply deny failing on nightly.

The thing is that clippy does not support another output than text and the error messages in rust are changing very fast.

Drogglbecher commented 7 years ago

Alright, since these shitty windows builds are fixed hopefully (^^!) just let's do this. When really failing on nightly builds and it's not caused by clippy we can allow failing again since the issue is solved ;)

Drogglbecher commented 7 years ago

As discussed in gitter talk on 2017/06/01 -> closed