search

rust-marker / marker

An experimental linting interface for Rust. Let's make custom lints a reality
https://rust-marker.github.io/marker/
Other
144 stars 11 forks source link

Fix archive layout for marker_rustc_driver on ARM #299

Closed Veetaha closed 1 year ago

Veetaha commented 1 year ago

The layout of marker_rustc_driver-aarch64-unknown-linux-gnu.tar.gz and zip turns out to differ from the layout of all other artifacts. This is because this version of driver is compiled separately using a custom qemu setup, packaging and upload and so it went slightly wrong.

The difference is that the file inside of the archive contains the architecture suffix, but it shouldn't.

I've manually updated the current 0.3.0 release by downloading the marker_rustc_driver ARM build, decompressing it, renaming the file to marker_rustc_driver, and running the part of upload.sh script that does the packaging.

xFrednet commented 1 year ago

LGTM, thank you for the updated. From this change and the issues you created, is it right to assume that you tried implementing a few lints in Marker?

Veetaha commented 1 year ago

Yes, I implemented 5-ish lints in a private repository at work. We have ARM runners in that repo, therefore I found this problem.

xFrednet commented 1 year ago

Perfect, thank you for all the issues!