When last time I fixed the build of marker_rustc_driver on ARM I tested my changes only locally in an isolated folder where I manually "unit-tested" the upload.sh script. Of course, when the build happens on CI the folders layout is entirely different. That's why the ARM packaging script broke but in other way.
On CI we mount the . fodler as /artifacts in quemu, but . folder includes the marker_rustc_driver crate source code folder. So when we do cp target/release/marker_rustc_driver /artifacts/marker_rustc_driver we copy the binary inside of that folder...
I fixed this by mounting ./artifacts which is guaranteed to be an empty folder.
Also manually fixed and reuploaded the artifacts in 0.4:
xFrednet
commented
1 year ago
When last time I fixed the build of marker_rustc_driver on ARM I tested my changes only locally in an isolated folder where I manually "unit-tested" the
upload.shscript. Of course, when the build happens on CI the folders layout is entirely different. That's why the ARM packaging script broke but in other way.On CI we mount the
.fodler as/artifactsinquemu, but.folder includes themarker_rustc_drivercrate source code folder. So when we docp target/release/marker_rustc_driver /artifacts/marker_rustc_driverwe copy the binary inside of that folder...I fixed this by mounting
./artifactswhich is guaranteed to be an empty folder.Also manually fixed and reuploaded the artifacts in 0.4:
This time I tested it end-to-end in my fork repo