search

rust-marker / marker

An experimental linting interface for Rust. Let's make custom lints a reality
https://rust-marker.github.io/marker/
Other
142 stars 11 forks source link

Cargo: Fix compiling driver from sources outside of the marker repo on Windows #319

Closed Veetaha closed 11 months ago

Veetaha commented 11 months ago

Closes https://github.com/rust-marker/marker/issues/318

I immediately identified the problem by the logs because this bug is specific to Windows only.

It was described as "Problem 2" in the description of the PR https://github.com/rust-marker/marker/pull/217, although that appeared in a bit different place at that moment.

This is just a quick fix, it doesn't setup testing on CI. I just reproduced the problem manually on my windows laptop and fixed it.

Veetaha commented 11 months ago

I think it makes sense to do a patch release to at least test this workflow. I'll update the changelog

xFrednet commented 11 months ago

I'll trigger the release workflow, since it still seems to require some changes to the branch protection rules

Veetaha commented 11 months ago

I don't think it requires, try without changes

xFrednet commented 11 months ago

Too late, I'll do it the next time. This should also fix the ARM archives :+1: