search

rust-math / intel-mkl-src

Redistribute Intel MKL as a crate
Other
77 stars 22 forks source link

Remove use * for external crates #70

Closed hombit closed 1 year ago

hombit commented 2 years ago

Remove wildcard use statements from intel-mkl-tool, because it causes problems like #68

Fix #68

hombit commented 2 years ago

Hi @termoshtt, please could you look into this? The issue #68 is really annoying and I see a lot of troubles people have with it

jianshu93 commented 2 years ago

I have the same build error. How use specify version 1.0.48 for a package depending ton it?

THanks,

Jianshu

hombit commented 2 years ago

@jianshu93 This PR resolves the root of the problem, it doesn't pin or limit anyhow version used by intel-mkl-tool. I temporary solved this issue in my project in the same way as others did: just specified anyhow version in my Cargo.toml: https://github.com/light-curve/light-curve/commit/15364a8fc1e254f25d1ae82ed33388d4ec290ba5

jianshu93 commented 2 years ago

Thanks for quick response.

Jianshu

adam-azarchs commented 2 years ago

Depending on what features are enabled, this is also an issue in https://github.com/rust-math/intel-mkl-src/blob/84a464e4f32ea658c17e5b4843af64b784abc4d6/intel-mkl-src/build.rs#L25

hombit commented 2 years ago

@adam-azarchs this PR was for intel-mkl-tool only, but I can do the same for other two crates as well

hombit commented 2 years ago

Thank you, @adam-azarchs, I did the same change in intel-mkl-src/intel-mkl-src/build.rs

njaard commented 2 years ago

@hombit I have forked this crate and applied this patch. https://github.com/njaard/mkl-src/

With appreciation to @termoshtt I'd like to ask you to make further contributions to my fork's repository due to the original author's absence.