rust-minidump / minidump-writer

Rust rewrite of breakpad's minidump_writer
MIT License
68 stars 17 forks source link

Fix mac modules #42

Closed Jake-Shadle closed 2 years ago

Jake-Shadle commented 2 years ago

When iterating over the loaded module to gather their metadata, only the main executable file path was being read correctly due to an oversight in the reading of the task memory, causing the read to fail and the module to be skipped and not written to the minidump. Now the file path is capped to a generous 8k, the same as Breakpad, which no longer runs into the issue. I also made it so that failing to read the file path for the module won't skip the module entirely any longer since that is rather harsh.

Resolves: #41