search

rust-minidump / minidump-writer

Rust rewrite of breakpad's minidump_writer
MIT License
68 stars 17 forks source link

Remove the windows-sys dependency #60

Closed gabrielesvelto closed 2 years ago

gabrielesvelto commented 2 years ago

Resolves: #58

gabrielesvelto commented 2 years ago

The bindings are lifted from windows-sys, save for the structures used in minidump callbacks which are replaced with dummies (we don't use them and they use a zillion different types). This isn't great because I have to make the bindings public in order to use them from the tests; I'm not sure if there' s a way to expose them just to the test but not the the crate's users.

Jake-Shadle commented 2 years ago

Oh nvm, it's because it's an outer attribute so applies to the main function so my change would also fix the build issue.