Stabilize ARM and AArch64 support on both Linux and Android, add support for x86-64 on Android

rust-minidump / minidump-writer

Rust rewrite of breakpad's minidump_writer

MIT License

68 stars 17 forks source link

Stabilize ARM and AArch64 support on both Linux and Android, add support for x86-64 on Android #81

Closed gabrielesvelto closed 1 year ago

gabrielesvelto commented 1 year ago

This change looks reasonable, but we really should find a nice way of adding tests, or at least sanity checks of some of this stuff to make reviews easier.

Is it possible to run tests on Android hosts in GitHub CI? I suppose we could use an emulator, that'd cover the x86-64 part at least. Once I merge this into Firefox we'll be running end-to-end tests on both Android hardware and the emulator but it'll still be nicer to have tests here.

Jake-Shadle commented 1 year ago

Well tests are harder for Android, when saying sanity checks I was more thinking just dumping out byte buffers and ensuring they can be interpreted correctly across changes in the code/libc/nix, but obviously has much lower value. But might be worth at least mentioning that Firefox is running more tests in addition to those in the repo.