search

rust-ml / linfa

A Rust machine learning framework.
Apache License 2.0
3.7k stars 243 forks source link

Is the `nu` parameter used incorrectly, for svm regression? #317

Open marcusbuffett opened 11 months ago

marcusbuffett commented 11 months ago

Was just browsing through the source, and this seemed weird, I could be totally off-base so feel free to just close, but in fit_nu, nu is the last param , but when it's called, nu is the second-to-last param, and c is the last param: https://github.com/rust-ml/linfa/blob/master/algorithms/linfa-svm/src/regression.rs#L144-L145

YuhanLiin commented 11 months ago

Not sure about this one. @bytesnake You wrote the SVM implementation right? Any ideas?