rust-mobile / android-activity

Glue for building Rust applications on Android with NativeActivity or GameActivity
251 stars 49 forks source link

Release beta version to be included into winit beta #109

Closed kchibisov closed 1 year ago

kchibisov commented 1 year ago

cargo disallows publishing with unspecified dependencies, so every crate must be on crates.io when doing so.

MarijnS95 commented 1 year ago

I will publish a beta for the ndk(-sys) crates and subsequently PR those here so that @rib can release an android-activity beta. I have a few more breaking changes to sort out and this should buy us some time.

kchibisov commented 1 year ago

I think android-activity doesn't depend on any new changes from ndk so we can release as is. @rib on #winit said the same if it matters, that he can just cut it, though, not sure when...

MarijnS95 commented 1 year ago

@kchibisov that'd be very inconvenient to end-users if we intend to bump the ndk in winit but not in android-activity, leading to duplicate dependencies at best and unnecessary symbol/type incompatibilities at worst?

kchibisov commented 1 year ago

@MarijnS95 I need to bump android-activity, not ndk though.

kchibisov commented 1 year ago

Also, this is all for beta, because I can't publish winit beta because of android activity git dependency in winit right now. For the actual release we'll bump everything to stable versions.

MarijnS95 commented 1 year ago

@kchibisov sure, all good if you/we still intend to do an ndk breaking bump in parallel with the winit release, just thought it may be useful to incorporate the ndk in the beta?

kchibisov commented 1 year ago

@MarijnS95 if you want to deal with it sure, but beta was nearly published until cargo complained about the git dependency, so it's sort of missed... it's not like we're in the rush, it's just a bit weird that I've merged the winit beta release PR and hasn't pushed it yet...

rib commented 1 year ago

Okey, I've just published 0.5.0-beta.0 to crates.io which winit should be able to use for its beta.1 @kchibisov

MarijnS95 commented 1 year ago

Just at the same time I thought to push for an NDK relese after all, guess I just missed out on the window... but as said above it doesn't really matter, though might be nice if we can include it in the next effort.

rib commented 1 year ago

I mean I could spin a beta.1 right now

MarijnS95 commented 1 year ago

@rib thanks, let's use this opportunity then. Publishing as we speak, keep an eye out for the CI:

https://github.com/rust-mobile/ndk/actions/runs/5871521189

MarijnS95 commented 1 year ago

It's done:

https://crates.io/crates/ndk-sys/versions https://crates.io/crates/ndk/versions

And the upgrade on the android-activity side: https://github.com/rust-mobile/android-activity/pull/113

Thanks again!

MarijnS95 commented 1 year ago

I bumped all these in winit as a test and it seems like everything is still compatible :tada:

rib commented 1 year ago

Okey, cool, 0.5.0-beta.1 published! :)

rib commented 1 year ago

thanks for the ndk/ndk-sys releases @MarijnS95!