search

rust-mobile / android-activity

Glue for building Rust applications on Android with NativeActivity or GameActivity
238 stars 46 forks source link

README: Update crate version in `Cargo.toml` example #143

Closed MarijnS95 closed 9 months ago

MarijnS95 commented 9 months ago

Apart from needing to fixup the NonNull::new() change, this looks good to me.

Must have misread that the Option it was assigned to a let binding rather than returned, while trying to scan for similar patterns that could use let-else. Changed it to a map now but perhaps it is better reverted (or turned into an if let Some(..) = NonNull::new { ...; Some(x) } else { None }).

rib commented 9 months ago

Changed it to a map now ...

yeah, seems reasonable to me