search

rust-mobile / android-activity

Glue for building Rust applications on Android with NativeActivity or GameActivity
238 stars 46 forks source link

native-activity/input: AND with `EVENT_ACTION_MASK` when extracting action #147

Closed ArthurCose closed 7 months ago

ArthurCose commented 9 months ago

Partially fixes #146. Possibly fully fixes the issue as I haven't encountered any issues with multitouch positions with winit on Android.

torokati44 commented 7 months ago

Pardon me, just passing by, but... why is OR in the PR title, when the added operator is &? 🤔

rib commented 7 months ago

Pardon me, just passing by, but... why is OR in the PR title, when the added operator is &? 🤔

hmm, yeah title should have been updated and then I also copy & pasted that for the changelog, oops.

MarijnS95 commented 7 months ago

Yeah so the commit title in the repo and changelog will be wrong, but the PR title and GitHub release are fixed to mention AND at least :)

@rib side-note: the changelog uses [0.2] link labels, but those tags are never specified to point to a link, e.g. [0.2]: https://github.com/rust-mobile/android-activity/releases/tag/v0.2.0.

rib commented 7 months ago

@rib side-note: the changelog uses [0.2] link labels, but those tags are never specified to point to a link, e.g. [0.2]: https://github.com/rust-mobile/android-activity/releases/tag/v0.2.0.

yeah I guess we could turn those into links like that. The Keep a Changelog reference that's linked in the changelog does that, so would be nice to be consistent with that.

Yeah so the commit title in the repo and changelog will be wrong, but the PR title and GitHub release are fixed to mention AND at least :)

we can also fly-by fix up the changelog the next time that gets touched.

MarijnS95 commented 7 months ago

Exactly that, yes :)