search

rust-mobile / android-rs-glue

Glue between Rust and Android
Apache License 2.0
905 stars 111 forks source link

Circle CI update with readme fix. #227

Closed philip-alldredge closed 5 years ago

philip-alldredge commented 5 years ago

@mb64

226 did not publish the docker image as hoped. The error messages and warnings produced are below. This pull requests reverts the README to reference my docker image until the automated build is fixed. It should also fix the security warning. However, the warning appears to be just a warning and the real error is the username or password is incorrect. I do not expect this to fix the publishing issue.

I recommend pushing so that the README will point to the newer docker image until we can workout the authentication issues with publishing. I don't have access to the Circle CI control panel so someone else will need to fix that part or grant me access.

!/bin/sh -eo pipefail

docker login -u $DOCKERHUB_LOGIN -p $DOCKERHUB_PASSWORD docker push IMAGE_NAME WARNING! Using --password via the CLI is insecure. Use --password-stdin. Error response from daemon: Get https://registry-1.docker.io/v2/: unauthorized: incorrect username or password Exited with code 1

mb64 commented 5 years ago

I'll merge for now, and cc @tomaka to fix updating the Docker image.