Fixed the `mem::uninitialized` warnings

rust-mobile / android-rs-glue

Glue between Rust and Android

Apache License 2.0

905 stars 111 forks source link

Fixed the `mem::uninitialized` warnings #240

Closed OptimisticPeach closed 5 years ago

OptimisticPeach commented 5 years ago

Used MaybeUninit to solve the warnings and also added a few dyns where they were missing.

OptimisticPeach commented 5 years ago

I'm not quite sure why they didn't compile 😕

philip-alldredge commented 5 years ago

Looks like a race condition to me. cargo-apk creates a debug certificate if it can't find one. Since the tests run in a clean environment and are running in parallel, it appears to have attempted to create the file in two separate tests.

mb64 commented 5 years ago

Hmm ... this seems to be a race condition triggered by running the tests in parallel. I'll make a PR that fixes it. In the meantime, LGTM, so I'll merge it. Thanks for your work on this!

Edit: Looks like @philip-alldredge beat me to it on that explanation!