search

rust-mobile / cargo-apk

Helps cargo build APKs
Apache License 2.0
101 stars 28 forks source link

Release cargo-apk-0.9.7 #4

Closed MarijnS95 closed 1 year ago

MarijnS95 commented 1 year ago

Fixes https://github.com/rust-windowing/android-ndk-rs/issues/375

Depends on #3

Initially opened as https://github.com/rust-windowing/android-ndk-rs/pull/376

rib commented 1 year ago

Now that we have merged stuff in this repo I think it will be a bit tricky to rebase and change any of the patches on the top of the filtered repo without confusing github (it will change commit hashes)

That's ok if we agree to address any issues via new patches on top + PRs from now on.

Hopefully all the big stuff is fine.

MarijnS95 commented 1 year ago

@rib If that's re. my comments on your initial porting commits, I think pushing fixes to address those comments on top (via a PR for review) is fine. I wasn't really sure if you were still planning on force-pushing though I was already told to not use the android-ndk-rs repo for these crates anymore, and really wanted to get this release out :)

rib commented 1 year ago

Right, esp if spinning a release from here we definitely wont want to force push anything here any more, so we can aim to handle any feedback or issues with the patches I made via PRs.

MarijnS95 commented 1 year ago

Can filter-branch also transplant the tags for cargo-apk and ndk-build? Maybe to late now to figure that out in retrospective, maybe for the other repos though?

rib commented 1 year ago

Can filter-branch also transplant the tags for cargo-apk and ndk-build? Maybe to late now to figure that out in retrospective, maybe for the other repos though?

I'm not sure if that was an option but yeah we'll just have to recreate older release tags manually to bring those across

MarijnS95 commented 1 year ago

I just pushed the few that I needed to create the release, having the rest would be nice for back-reference but might be better to leave those to the original repo, it's a lot of work unless you start comparing patchids (for the subdirectory if possible) or commit titles that have ndk-build-*/cargo-apk-* tags on them.

rib commented 1 year ago

It's probably best to just defer to the tags in this repo for older releases, considering that the standalone repo won't build correctly for all those past commits that correspond to releases (unless you would back port the changes I made on top).

MarijnS95 commented 1 year ago

Correct, it'll only generate lots of "failed CI" traffic.