search

rust-mobile / ndk

Rust bindings to the Android NDK
Apache License 2.0
1.14k stars 112 forks source link

Removes ndk-glue + ndk-macro as part of #372 modularization #373

Closed rib closed 1 year ago

rib commented 1 year ago

The ndk-glue and ndk-macro subdirectores have been split into a stand-alone repository at: https://github.com/rust-mobile/ndk-glue

This is being done as part of the modularization effort described in issue #372

The stand-alone repository was filtered like this:

git clone https://github.com/newren/git-filter-repo
git clone https://github.com/rust-windowing/android-ndk-rs.git ndk-glue
cd ndk-glue
py ../git-filter-repo/git-filter-repo \
    --path ndk-glue --path ndk-macro \
    --path ndk-examples --path-rename ndk-examples:examples \
    --path LICENSE-APACHE --path LICENSE-MIT \
    --path Cargo.toml --path rustfmt.toml \
    --path .github --path .gitignore

The last commit in this repo that is included within the stand-alone repository is 107f03e3858bdced3a7a898e43b339b73d7fc1af

Although ndk-glue is also being deprecated at the same time as splitting it out this commit doesn't make any README changes for this repo yet which will be addressed separately.

For now the ndk-examples continue to use the ndk-glue crate (the 0.7 release) and the current plan is to move these examples to the cargo-apk crate where they will be ported to use android-activity

rib commented 1 year ago

In addressing the last CI failure I've added a note that the ndk-examples are now using the 0.7 release of ndk-glue instead of the in-tree version. This requires a [path.crates-io] to ensure a consistent choice over the ndk crate implementation.

This doesn't look to port the examples away from ndk-glue at this point since the current idea is that the examples will actually be removed from this repo and instead maintained within the cargo apk repo (it's more compelling to have examples in the cargo apk repo for testing that the tool can package and deploy those examples as part of its CI)

Even if we decide we want to keep a copy of these examples in this repo too, it seems reasonable to handle porting to android-activity separately.

rib commented 1 year ago

I'm closing this PR since I think it's going to be more practical to track all the removal changes related to #372 together

Please see https://github.com/rust-windowing/android-ndk-rs/pull/374 instead (currently a draft until I have made a patch to remove cargo-apk, ndk-build and ndk-examples)