rust-mobile / ndk

Rust bindings to the Android NDK
Apache License 2.0
1.11k stars 110 forks source link

ndk/bitmap: Gate `BitmapCompressError` behind `api-level-30` #462

Closed Rodrigodd closed 7 months ago

Rodrigodd commented 8 months ago

Otherwise there is a compilation error when building with only the feature bitmap, due to the inexistence of the DataSpace type. DataSpace is defined with api-level-28, but this BitmapCompressError is only used by Bitmap::compress() and Bitmap::compress_raw(), which are only available with api-level-30.

MarijnS95 commented 8 months ago

Well that is fair even though this will all be deleted again soon. We cannot merge, yank, and re-release this without a changelog entry though.

Rodrigodd commented 8 months ago

@MarijnS95 Added a changelog entry.