search

rust-ndarray / ndarray-stats

Statistical routines for ndarray
https://docs.rs/ndarray-stats
Apache License 2.0
201 stars 25 forks source link

clippy and a bugfix #59

Closed felix-clark closed 4 years ago

felix-clark commented 4 years ago

Fixed most clippy warnings. Two remain but appear to be in the ndarray s![] macro itself.

One warning highlighted that the ne() implementation for NotNone which actually called eq() on the inner field. A default implementation of ne() is implied by eq(), so the buggy implementation could simply be removed.

LukeMathWalker commented 4 years ago

Good catch on eq and neq - thanks for taking the time! 💯