Use merge queue - Githubissues

rust-ndarray / ndarray

ndarray: an N-dimensional array with array views, multidimensional slicing, and efficient operations

https://docs.rs/ndarray/

Apache License 2.0

3.43k stars 295 forks source link

Closed bluss closed 4 months ago

bluss commented 4 months ago

@adamreichold's recipe

We don't run CI on the main branch at all any more because all commits are tested before being put there.
Which tests are run is not differentiated by branch name but by event, either pull requests or merge queues.
PR run should small and fast for quick feedback on proposed changes.
Pre-merge checks should be complete so that the main branch is always is a known good state.

bluss commented 4 months ago

Wish me luck

bluss commented 4 months ago

Well, bad luck, it's supposed to run both yaml files for the merge queue :thinking:

adamreichold commented 4 months ago

Well, bad luck, it's supposed to run both yaml files for the merge queue 🤔

Are you sure merge queues are enabled?

bluss commented 4 months ago

yes, it used the merge queue for this one

adamreichold commented 4 months ago

It might be necessary to explicit configure the require CI workflows for merge queues in the branch protection rules (of the main branch).

bluss commented 4 months ago

There's a lot of unnecessary and unintiuitive caveats mentioned here https://stackoverflow.com/a/76740962 and hopefully that's the right track..

All docs seem to suggest 'Require status checks to pass before merging' is an independent setting and not necessary, but something's going on.