rust-ndarray / ndarray

ndarray: an N-dimensional array with array views, multidimensional slicing, and efficient operations
https://docs.rs/ndarray/
Apache License 2.0
3.56k stars 299 forks source link

Test using cargo-careful #1371

Closed bluss closed 6 months ago

bluss commented 6 months ago

Suggested by @adamreichold.

I think we could test with miri too, the problem is that it's very slow.

bluss commented 6 months ago

it ran correctly here: https://github.com/rust-ndarray/ndarray/actions/runs/8216936059/job/22472060567

adamreichold commented 6 months ago

I think we could test with miri too, the problem is that it's very slow.

My understanding was that Miri would not handling calling into BLAS et al.

bluss commented 6 months ago

I see. It's been attempted before, such as by jturner in commit 784a9a842b42313eb3ce71b793bf80c777a1fef0 apparently. He added a miri runner in matrixmultiply at least, but we don't have it here.