rust-ndarray / ndarray

ndarray: an N-dimensional array with array views, multidimensional slicing, and efficient operations
https://docs.rs/ndarray/
Apache License 2.0
3.43k stars 295 forks source link

Adds `squeeze()` to dynamic arrays #1396

Open barakugav opened 6 days ago

barakugav commented 5 days ago

Moreover, can you please merge master in your branch?

Rebased

nilgoyette commented 14 hours ago

Thank you for your contribution.

nilgoyette commented 13 hours ago

@adamreichold I don't have the right to merge this branch. There are several errors when I run cargo clippy --features docs on beta. Some of them are important and would necessitate a their own PR, like

warning: current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.80.0`
  --> src/data_repr.rs:75:27
   |
75 |         unsafe { self.ptr.add(self.len) }

There's no error when I use stable. I'm not sure why we run clippy on beta...?