Open akern40 opened 1 month ago
That's a good question https://github.com/rust-ndarray/ndarray/pull/967 That guy seems rather confident about it being for owned arrays, but leaves no trace why, I also don't get it. :sweat_smile:
If I try to reconstruct, I think it's a little bit about the mindset and the whole picture.
Vec::swap_remove
I think you have a good point, but if we open this method up to being used on all mutable views, then the full effect of the method has to be explained, that it has taken the 'removed index' and placed it somewhere else.
I can't tell either - even rotate1_front
doesn't require DataOwned
, and the other functions don't, either. In fact, the method already uses views!
the full effect of the method has to be explained, that it has taken the 'removed index' and placed it somewhere else
We already do explain the full effect: https://github.com/rust-ndarray/ndarray/blob/492b2742073cf531635d701ced4e01a827038f69/src/impl_methods.rs#L2984-L2987
While working on some code, I ran across
remove_index
and noticed that it has a bound ofS: DataOwned
, but I'm not sure why?As this method documents, it does not actually change the allocation of the underlying array, and none of its internal methods require
DataOwned
. Can this bound be removed? Or am I missing something?