Strongly typed strides - Githubissues

rust-ndarray / ndarray

ndarray: an N-dimensional array with array views, multidimensional slicing, and efficient operations

https://docs.rs/ndarray/

Apache License 2.0

3.52k stars 297 forks source link

Strongly typed strides #283

Open bluss opened 7 years ago

bluss commented 7 years ago

Separate type for D: Dimension and its corresponding stride
Strides are signed integers (isize)

Robbepop commented 7 years ago

I like this refactoring! Personally I was slightly confused about this when scanning through the source code of ndarray.

bluss commented 7 years ago

It does keep it simple, less generics noise and repetition. However it is time..

bluss commented 7 years ago

Postponed to after 0.9. Potentially we want a bigger reorganization of Dimensions

Robbepop commented 7 years ago

Good decision - 0.9 is already pretty big!

bluss commented 7 years ago

Yeah; I don't know how I found so many technically breaking changes to add. There will always be intensive and not so intensive periods.

Robbepop commented 7 years ago

Yes, but I personally really like the way you handle refactoring of code and breaking changes in your projects. You do not fear them, you approach them and simply introduce all those new shiny features instead of going with an overly conservative approach that avoids to ever break anything which sadly is a strategy in a few crates ... 👍 But who am I to judge. ;)

bluss commented 7 years ago

In this case they have been many technically breaking but almost no actual effect on end users. All changes are judged for their effect, not the technically breaking status. Which is why it is hard to change how dimensions work.