search

rust-netlink / netlink-proto

Other
8 stars 14 forks source link

fix: keep forwarding Ack & Done & Noop messages #4

Closed xtexChooser closed 7 months ago

xtexChooser commented 1 year ago

Closes rust-netlink/netlink-sys#5

I do not know why these packets should be dropped. In some cases, like WireGuard(rust-netlink/netlink-sys#5 gluxon/wireguard-uapi-rs#28 embeddable-wg-library/wireguard.c#L1185) and nl80211(jbaublitz/neli#134), The request only responses Ack. Without Ack, we can not know whether an operation is done actually.

cathay4t commented 1 year ago

I do not know why these packets should be dropped. is not a great commit message for a patch.

Could you investigate kernel code and provide detailed reason?

You may wait me to do the investigation but it might take a while.

cathay4t commented 10 months ago

The patch has been merged as 563e862b6cae6b30bc546d553e5f112c1649e301

Closing as already done.

cathay4t commented 7 months ago

My bad on closing this without patch been merged. Let me create new PR and continue the work.

cathay4t commented 7 months ago

Let me reopen this PR and work on it for full context.

cathay4t commented 7 months ago

@xtexChooser I know it has been 1 year, but could you review new PR at https://github.com/rust-netlink/netlink-proto/pull/22 and let me know whether that fit your requirements on wireguard netlink protocol?

xtexChooser commented 7 months ago

Hi! Sorry for my late coming. It seems good to me. Thanks!