search

rust-nostr / negentropy

Rust implementation of the negentropy set-reconcilliation protocol.
MIT License
17 stars 3 forks source link

make graph errors out #8

Closed mikedilger closed 2 weeks ago

mikedilger commented 2 weeks ago

Describe the bug
Running "make graph" gives an error (doesn't understand the argument "--release")

CARGO_PROFILE_RELEASE_DEBUG=true cargo flamegraph --release -p perf -o flamegraph.svg
error: Found argument '--release' which wasn't expected, or isn't valid in this context

    Did you mean '--reverse'?

    If you tried to supply `--release` as a value rather than a flag, use `-- --release`

USAGE:
    cargo flamegraph --reverse

For more information try --help
make: *** [Makefile:15: graph] Error 2

To Reproduce
$ make graph

Expected behavior 

myr negentropy] make graph
automatically selected target perf in package perf as it is the only valid target
    Finished `release` profile [optimized + debuginfo] target(s) in 0.00s
Client init took 0 ms
Relay items: 1000000
Relay reconcile took 30 ms
Client reconcile took 72 ms
[ perf record: Woken up 16 times to write data ]
[ perf record: Captured and wrote 3.901 MB perf.data (242 samples) ]
writing flamegraph to "flamegraph.svg"

Build environment

Additional context
I'm not sure if the suggestion of "--reverse" makes any sense, or if release just isn't needed, or if release should be passed in a different way, so I'm opening this issue instead of submitting a PR.

yukibtc commented 2 weeks ago

Weird, to me works. What version of cargo flamegraph are you using?

Anyway, I saw that by default release profile is used so I'm going to remove it.

mikedilger commented 2 weeks ago

I was on 0.6.2, upgrading now to 0.6.5, but I guess this is irrelevant now. Thanks.