rust-num / num-complex

Complex numbers for Rust
Apache License 2.0
232 stars 50 forks source link

Create ComplexFloat trait to model Floats as a subset of Complex<T> #95

Closed obsgolem closed 2 years ago

obsgolem commented 3 years ago

Resolves #2. Replaces #53. Nearly all the work here was already done by YakoYakoYokuYoku. I have merely updated it to master and made a few discretionary changes which I think improve the work slightly. More unit tests will be coming.

YakoYakoYokuYoku commented 3 years ago

If you want it you could add a Co-authored-by: Martin Reboredo <yakoyoku@gmail.com> at any one of your commit messages. LGTM otherwise.

obsgolem commented 3 years ago

I will certainly do so. Thanks!

obsgolem commented 2 years ago

Ping, any chance I could get a review before end of year?

obsgolem commented 2 years ago

Bump

bluss commented 2 years ago

Awesome work, I'm happy this trait comes alive.

cuviper commented 2 years ago

I tweaked a few more things, but I think we're good. :crossed_fingers: Thanks!

bors r+

bors[bot] commented 2 years ago

Build succeeded: