rust-num / num-derive

Procedural macros to derive numeric traits in Rust
Apache License 2.0
166 stars 24 forks source link

Update to syn-2 #54

Closed maurer closed 1 year ago

maurer commented 1 year ago

Also moves a test out of doctest compilefail since syn-2 will build it correctly even without the "full" feature.

cuviper commented 1 year ago

Do we use anything that would need "full" anymore? If not, I think we should just drop that feature. We can bump semver for the new MSRV requirement while we're at it, so a breaking feature change is ok.

maurer commented 1 year ago

I fixed up the .unwrap() call and added an additional commit to remove the full-syntax feature. There are still some things that are not present in syn without full, but none of them seem to correspond to complex discriminants.

glandium commented 1 year ago

@cuviper is there anything holding this up?

cuviper commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

cuviper commented 1 year ago

is there anything holding this up?

Lack of time and attention... but it's published now!